Skip to content

fix: replace deprecated srfit pdf/structure API in examples - #116

Merged
sbillinge merged 1 commit into
diffpy:mainfrom
cadenmyers13:fix-example-deprecations
Nov 17, 2026
Merged

sbillinge merged 1 commit into
diffpy:mainfrom
cadenmyers13:fix-example-deprecations

Conversation

@cadenmyers13

Copy link
Copy Markdown
Contributor

Import from diffpy.cmipdf and diffpy.cmistructure instead of diffpy.srfit.pdf and diffpy.srfit.structure, and use set_structure, set_qmax, set_qmin, get_scatterers, get_lattice and .structure in the example scripts and notebooks under docs/examples.

Import from diffpy.cmipdf and diffpy.cmistructure instead of
diffpy.srfit.pdf and diffpy.srfit.structure, and use set_structure,
set_qmax, set_qmin, get_scatterers, get_lattice and .structure in the
example scripts and notebooks under docs/examples.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cadenmyers13

Copy link
Copy Markdown
Contributor Author

@sbillinge ready for merge

@sbillinge

Copy link
Copy Markdown
Contributor

do you want me to merge with failing tests? Or we should push out a quick release of srfit and make sure it is working?

@cadenmyers13

cadenmyers13 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor Author

@sbillinge Yes please merge. This fails because cmipdf and cmistructure are not on cf yet... A srfit release wont fix this. I made issues to ensure they are on cf before the next release

@sbillinge
sbillinge merged commit dfeddb9 into diffpy:main Nov 17, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants